Migrate to nanoTime for time* methods, improve API DX #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10678212513Details
💛 - Coveralls |
dfakhritdinov
approved these changes
Sep 2, 2024
src/main/scala/com/evolutiongaming/prometheus/ObserveDuration.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/evolutiongaming/prometheus/ObserveDuration.scala
Outdated
Show resolved
Hide resolved
timeFunc and timeFuture used millisecond precision, which lead to issues like Summary quantiles being skewed towards 0 if measured latencies are close to 1 ms. To fix that: - time* methods use System.nanoTime() now - deprecate specific time*Nano methods, millisecond precision shouldn't be a choice to avoid mistakes - improve method naming, document all time-related public functionality - deprecate unused TemporalOps implicit conversion - overall developer experience improvements This change breaks source compatibility for some usages, but binary compatibility is preserved.
migesok
force-pushed
the
bugfix/use-nanotime-by-default
branch
from
671f18b to
fecdce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeFuncandtimeFutureused millisecond precision, which lead to issues likeSummaryquantiles being skewed towards 0 if measured latencies are close to 1 ms.To fix that:
System.nanoTime()nowTemporalOpsimplicit conversionThis change breaks source compatibility for some usages, but binary compatibility is preserved.