Cross-compile for Scala 3

[grzegorz-bielski]

Updated all deps besides cassandra-driver, moved to testcontainers instead of cassandra-launcher like in here, removed pureconfig derivation and cross compiled against 3.3.3, 2.13.13 and 2.12.19.

TODO:
- [ ] add https://github.com/scalacenter/sbt-version-policy - Will do it in separate PR.

[coveralls]

Pull Request Test Coverage Report for Build 8457153266

Details

• 73 of 73 (100.0%) changed or added relevant lines in 13 files are covered.
• 8 unchanged lines in 7 files lost coverage.
• Overall coverage increased (+12.7%) to 89.319%

---

Files with Coverage Reduction	New Missed Lines	%
scassandra/src/main/scala/com/evolutiongaming/scassandra/Masked.scala	1	0.0%
scassandra/src/main/scala/com/evolutiongaming/scassandra/ReconnectionConfig.scala	1	40.0%
scassandra/src/main/scala/com/evolutiongaming/scassandra/QueryConfig.scala	1	82.35%
scassandra/src/main/scala/com/evolutiongaming/scassandra/SocketConfig.scala	1	75.0%
scassandra/src/main/scala/com/evolutiongaming/scassandra/LoadBalancingConfig.scala	1	11.11%
scassandra/src/main/scala/com/evolutiongaming/scassandra/ReplicationStrategyConfig.scala	1	77.78%
scassandra/src/main/scala/com/evolutiongaming/scassandra/SpeculativeExecutionConfig.scala	2	20.0%

Totals
Change from base Build 7741500935:	12.7%
Covered Lines:	669
Relevant Lines:	749

---

💛 - Coveralls

[Z1kkurat]

LGTM, thanks!

[rtar]

I did not double check if all properties are tested in unit tests. May be will do later.

[grzegorz-bielski]

@rtar, @Z1kkurat do you think we can merge it soon?

[Z1kkurat]

@rtar, @Z1kkurat do you think we can merge it soon?

@rtar i have no objections, let's merge?

[rtar]

Yes, let's do it!

[rtar]

One note, though. If it was not tested for binary compatibility, it might need to be released as a new major version with all the consequences involved.

[Z1kkurat]

I just thought: does pureconfig derive codecs that can read only dash-separated names, or does it allow dots too? In other words, is it able to read only "connect-timeout", or can it read connect.timeout too? If the latter is the case then we need to support that

[grzegorz-bielski]

@Z1kkurat I believe . would mean nesting in HOCON.

By default pureconfig maps from camelCase values in case classes to kebab-case values in config files. This can be configured by ProductHint during derivation, but we weren't changing it.

[Z1kkurat]

One note, though. If it was not tested for binary compatibility, it might need to be released as a new major version with all the consequences involved.

there were no changes to the API though, why do you think the compatibility could be broken?

[Z1kkurat]

@rtar Grzegorz updated the version to 6.0.0, as you asked (though I think it was unnecessary). Shall we merge this, please, or do you have any other concerns? This PR is quite big, and I don't want to delay it for longer

[rtar]

I suggest to merge it. I think it is fine to release it as 5.x if binary compatibility is maintained.

[Z1kkurat]

@grzegorz-bielski, without going over all the files again, could you confirm only internals were changed without changes to signatures and APIs? I'd honestly prefer to keep the version to 5.x, otherwise it's going to be a lot of pain further down the road

[grzegorz-bielski]

@Z1kkurat The only change in the main API was splitting the implicit config readers to a separate trait like AuthenticationConfigImplicits, which is then mixed with original object like AuthenticationConfig. Variable names were not renamed and type signatures not modified, so the change should be backwards compatible.

Edit: I found one issue, which is now fixed.

[grzegorz-bielski]

I have set up the sbt-version-policy locally ( I don't want to include it in this PR to reduce the scope)

After f175a86 sbt scassandra / mimaReportBinaryIssues doesn't report any issues anymore but sbt scassandra / versionPolicyCheck returns:

[error]   ch.qos.logback:logback-classic: missing dependency
[error]   ch.qos.logback:logback-core: missing dependency

Not sure why, since I didn't remove it. 🤔

[rtar]

I suggest to merge it, and I think we can consider it binary compatible (i.e. release it as 5.x).

I suspect one of your updated dependencies removed logback, hence is your error. You can add it manually back, but I think it is fine without it, either.

[grzegorz-bielski]

@rtar Should I change the version to 5.1.0 or can we leave at 5.0.3-SNAPSHOT ?

[rtar]

I am not sure, but I think you should use 5.0.3-SNAPSHOT if it is source-compatible and binary-compatible, and use 5.1.0-SNAPSHOT if it is only binary-compatible.

I think you might also use 5.1.0-SNAPSHOT to show the significance of having Scala 3 support.

To summarize, it is up to you 😊

[grzegorz-bielski]

Since it also removes the transitive logback dependency then let's go with 5.1.0-SNAPSHOT and