Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Producer.withLogging1/Consumer.withLogging1 for binary compatibility [CE2] #375

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

Z1kkurat
Copy link
Contributor

@Z1kkurat Z1kkurat commented Aug 24, 2023

This is a continuation of #373 and a back-port of #374

@Z1kkurat Z1kkurat changed the title Add Producer.withLogging1/Consumer.withLogging1 for binary compatibility Add Producer.withLogging1/Consumer.withLogging1 for binary compatibility [CE2] Aug 24, 2023
@coveralls
Copy link

coveralls commented Aug 24, 2023

Pull Request Test Coverage Report for Build 5964163842

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 75.835%

Changes Missing Coverage Covered Lines Changed/Added Lines %
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/Consumer.scala 0 1 0.0%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/Producer.scala 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerConverters.scala 1 95.08%
Totals Coverage Status
Change from base Build 5963872860: -0.1%
Covered Lines: 1271
Relevant Lines: 1676

💛 - Coveralls

@Z1kkurat Z1kkurat merged commit 5a75d42 into ce2 Aug 24, 2023
4 of 5 checks passed
@Z1kkurat Z1kkurat deleted the fix-compatibility-ce2 branch August 24, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants