Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProducerOf.apply2/ConsumerOf.apply2 for binary compatibility [CE2] #377

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Add ProducerOf.apply2/ConsumerOf.apply2 for binary compatibility [CE2] #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerOf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,17 @@ object ConsumerOf {
}
}

/** The sole purpose of this method is to support binary compatibility with an intermediate
* version (namely, 11.15.1) which had `apply1` method using `MeasureDuration` from `smetrics`
* and `apply2` using `MeasureDuration` from `cats-helper`.
* This should not be used and should be removed in a reasonable amount of time.
*/
@deprecated("Use `apply1`", since = "11.16.3")
def apply2[F[_] : Concurrent : ContextShift : ToTry : ToFuture : MeasureDuration : Clock](
executorBlocking: ExecutionContext,
metrics: Option[ConsumerMetrics[F]] = None
): ConsumerOf[F] = apply1(executorBlocking, metrics)

implicit class ConsumerOfOps[F[_]](val self: ConsumerOf[F]) extends AnyVal {

def mapK[G[_]: Applicative: Defer](
Expand Down
11 changes: 11 additions & 0 deletions skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerOf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,17 @@ object ProducerOf {
}
}

/** The sole purpose of this method is to support binary compatibility with an intermediate
* version (namely, 11.15.1) which had `apply1` method using `MeasureDuration` from `smetrics`
* and `apply2` using `MeasureDuration` from `cats-helper`.
* This should not be used and should be removed in a reasonable amount of time.
*/
@deprecated("Use `apply1`", since = "11.16.3")
def apply2[F[_]: Concurrent: ContextShift: MeasureDuration: ToTry](
executorBlocking: ExecutionContext,
metrics: Option[ProducerMetrics[F]] = None
): ProducerOf[F] = apply1(executorBlocking, metrics)

implicit class ProducerOfOps[F[_]](val self: ProducerOf[F]) extends AnyVal {

def mapK[G[_]: Monad: Defer](
Expand Down
Loading