Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatibility with kafka-clients 3.7.0, by using local version of NoOpConsumerRebalanceListener #416

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix compatibility with kafka-clients 3.7.0, by using local version of NoOpConsumerRebalanceListener #416

merged 1 commit into from
Mar 20, 2024

Conversation

johanmast
Copy link
Contributor

Fixes #415

@johanmast
Copy link
Contributor Author

@Z1kkurat @rtar please review this PR

@coveralls
Copy link

coveralls commented Mar 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8343905714

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 26 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.0%) to 96.926%
Files with Coverage Reduction New Missed Lines %
skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerLogging.scala 4 88.57%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerLogging.scala 22 92.28%
Totals Coverage Status
Change from base Build 7741811054: -1.0%
Covered Lines: 2144
Relevant Lines: 2212
💛 - Coveralls

@Z1kkurat Z1kkurat merged commit 17eeab7 into evolution-gaming:master Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Z1kkurat Z1kkurat Z1kkurat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with kafka-clients 3.7.0 due to usage of NoOpConsumerRebalanceListener
3 participants
@johanmast @coveralls @Z1kkurat