Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal node incompatibilities for LTS versions #91

Open
duncdrum opened this issue Jul 27, 2021 · 0 comments
Open

Fatal node incompatibilities for LTS versions #91

duncdrum opened this issue Jul 27, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@duncdrum
Copy link
Contributor

Under node 12 (as per documentation the min version)
we have an upstream incompatibility that causes the build to error:

error electron-builder@22.11.7: The engine "node" is incompatible with this module. Expected version ">=14.0.0". Got "12.22.1"

under node 14

error dugite-extra@0.1.14: The engine "node" is incompatible with this module. Expected version ">=10.11.0 <13". Got "14.15.5"

so compiling is currently broken.
@duncdrum duncdrum added the bug Something isn't working label Jul 27, 2021
@duncdrum duncdrum changed the title Fatal node incompatibilities fir LTS versions Fatal node incompatibilities for LTS versions Jul 27, 2021
This was referenced Jul 28, 2021
Open
Closed
Closed
duncdrum added a commit that referenced this issue Jul 30, 2021
@duncdrum
fix(build): ignore max node limitation
54af984 
see eclipse-theia/dugite-extra#49 we can yolo this one

adjust documenation

see #93
see #91
see #94
duncdrum added a commit that referenced this issue Jul 30, 2021
@duncdrum
ci(2): adjust install cmd
c810581 
see #91
duncdrum added a commit that referenced this issue Jul 30, 2021
@duncdrum
ci(2): adjust install cmd
3b7376a 
see #91
duncdrum added a commit that referenced this issue Aug 12, 2021
@duncdrum
doc(readme): bump min node
0beb0cc 
see #91
@ccheraa ccheraa mentioned this issue Aug 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@duncdrum