Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

175 stagedreferences from nursery #183

Merged
merged 15 commits into from
Dec 18, 2024
Merged

Conversation

nphias
Copy link
Collaborator

@nphias nphias commented Dec 12, 2024

Beginning of a work around the QueryManager

  • QueryManager with HolonFacade (shared access to the SpaceManager)
  • added QueryManager to the context
  • added traits to confine access to the SpaceManager's staging area / nursery
  • moved mutator functions out of public trait in nursery
  • renamed get_stage to get_all_holons
  • updated flake and packages

@nphias nphias requested a review from evomimic December 12, 2024 23:17
@nphias nphias force-pushed the 175-stagedreferences-from-nursery branch from e8566e8 to e908e75 Compare December 13, 2024 10:19
…y' into 175-stagedreferences-from-nursery

# Conflicts:
#	zomes/coordinator/dances/src/dancer.rs
#	zomes/coordinator/holons/src/commit_service.rs
#	zomes/coordinator/holons/src/space_manager.rs
#	zomes/coordinator/holons/src/staged_reference.rs
@evomimic
Copy link
Owner

Everything compiles and runs. Sweetests pass.

There is some additional simplification and segmentation I want to do to more clearly distinguish the architectural layers and ensure a better separation of concerns. For example, the HolonStageQuery trait includes methods that return Holons instead of HolonReference. These methods should not be offered by the Reference Layer. As another example, the method:

fn get_holon_by_index(&self,index: usize)-> Result<Rc<RefCell<Holon>>, HolonError>

is ONLY intended to be used by the internal implementation of StagedReference. Thus, a trait offering this method should belong (ONLY) to the SharedObjectsLayer and not be visible in the API to the ReferenceLayer.

More details are available in this discussion Limiting Direct Access to Holons discussion.

I'm going to approve and merge this PR and further refinements can be worked in smaller issues.

@evomimic evomimic merged commit d2c7a3f into main Dec 18, 2024
1 check passed
@evomimic evomimic deleted the 175-stagedreferences-from-nursery branch December 18, 2024 22:51
@nphias nphias self-assigned this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants