-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
175 stagedreferences from nursery #183
Conversation
e8566e8
to
e908e75
Compare
…private, cleaned up style
…y' into 175-stagedreferences-from-nursery # Conflicts: # zomes/coordinator/dances/src/dancer.rs # zomes/coordinator/holons/src/commit_service.rs # zomes/coordinator/holons/src/space_manager.rs # zomes/coordinator/holons/src/staged_reference.rs
Everything compiles and runs. Sweetests pass. There is some additional simplification and segmentation I want to do to more clearly distinguish the architectural layers and ensure a better separation of concerns. For example, the HolonStageQuery trait includes methods that return Holons instead of HolonReference. These methods should not be offered by the Reference Layer. As another example, the method:
is ONLY intended to be used by the internal implementation of StagedReference. Thus, a trait offering this method should belong (ONLY) to the SharedObjectsLayer and not be visible in the API to the ReferenceLayer. More details are available in this discussion Limiting Direct Access to Holons discussion. I'm going to approve and merge this PR and further refinements can be worked in smaller issues. |
Beginning of a work around the QueryManager