Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor for HolonWritable and HolonReadable traits #191

Merged
merged 2 commits into from
Dec 26, 2024
Merged

refactor for HolonWritable and HolonReadable traits #191

merged 2 commits into from
Dec 26, 2024

Conversation

nphias
Copy link
Collaborator

@nphias nphias commented Dec 25, 2024

  • added two new files
  • touched dances, holons, descriptors, tests
  • cleared some warnings
  • all tests passed

@nphias nphias requested a review from evomimic December 25, 2024 21:26
@evomimic evomimic merged commit fd396bb into main Dec 26, 2024
1 check passed
@evomimic evomimic deleted the 185-Refactor-HolonReference-Traits branch December 26, 2024 14:43
@evomimic
Copy link
Owner

Code looks good. All tests pass. PR approved.

@nphias nphias self-assigned this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evomimic evomimic Awaiting requested review from evomimic

Assignees

@nphias nphias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nphias @evomimic