Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

79 implement abandonstagedchanges dance #92

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

dauphin3
Copy link
Collaborator

No description provided.

@dauphin3 dauphin3 linked an issue May 30, 2024 that may be closed by this pull request
39 tasks
@dauphin3 dauphin3 requested a review from evomimic May 30, 2024 16:38
@evomimic
Copy link
Owner

evomimic commented Jun 1, 2024

I've completed the rewrite and am running tests... ran into an interesting problem that will require more thought:
H1 has AUTHORED_BY relationship to H2 and H3.
when H2 was abandoned, it was not removed from H1's relationship_map. (There is no way for H2 to know that it is referenced in some other staged_holon's relationship_map)

So on the second commit pass (committing relationships), H1 gets an error trying to commit its relationship to H2.

@evomimic
Copy link
Owner

evomimic commented Jun 1, 2024

In response to problem noted above, I re-designed the commit processing for relationships... to skip trying to create smartlinks for target references for which a HolonId is not available (e.g., because a StagedReference was Abandoned rather than Saved). This involved replacing HolonReference's commit_smartlink method with a get_id method and then having StagedCollection's add_smartlinks_for_collection method iterate through its vector of HolonReferences and create a smartlink to it ONLY if it has a holon_id.

@evomimic evomimic merged commit 6a3a6ac into main Jun 1, 2024
1 check failed
@evomimic evomimic deleted the 79-implement-abandonstagedchanges-dance branch June 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement AbandonStagedChanges Dance
2 participants