Implement Caching #7 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update-version2
…ache, i tested it and it should be working, there is a test function comemnted out in main. i added some imports due to when i ran it, it wasnt finding the folders, can remove those if you want as it is probably me and my environment.
dendenso
requested changes
Apr 25, 2025
…/tests folder directory and used the unittest suite to explore the conditions when the function would return an exception, valid/invalid data. made a seperate file for cached_get,.
dendenso
approved these changes
Apr 25, 2025
This was
linked to
issues
Apr 25, 2025
Closed
dendenso
approved these changes
Apr 28, 2025
johnnvij
reviewed
Apr 28, 2025
johnnvij
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added caching, used functools already built in python, and used lru cache, i tested it and it should be working, there is a test function commented out in main. i added some imports due to when i ran it, it wasnt finding the folders, can remove those if you want as it is probably me and my environment.