code review

ewallah · Mar 28, 2024 · 2a1859f · 2a1859f
1 parent d47f5af
commit 2a1859f
Show file tree

Hide file tree

Showing 11 changed files with 3 additions and 14 deletions.
diff --git a/classes/privacy/provider.php b/classes/privacy/provider.php
@@ -32,7 +32,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class provider implements \core_privacy\local\metadata\null_provider {
-
     /**
      * Get the language string identifier with the component's language
      * file to explain why this plugin stores no data.

diff --git a/lib.php b/lib.php
@@ -36,7 +36,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class repository_s3bucket extends repository {
-
     /** @var _s3client s3 client object */
     private $_s3client;
 

diff --git a/tests/behat/behat_repository_s3bucket.php b/tests/behat/behat_repository_s3bucket.php
@@ -34,7 +34,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class behat_repository_s3bucket extends behat_base {
-
     /**
      * Enable s3 bucket.
      *

diff --git a/tests/behatstep_test.php b/tests/behatstep_test.php
@@ -31,7 +31,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 final class behatstep_test extends \advanced_testcase {
-
     /**
      * Basic test of step.
      *

diff --git a/tests/delete_test.php b/tests/delete_test.php
@@ -32,7 +32,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 final class delete_test extends \advanced_testcase {
-
     /**
      * Test deleting a s3 bucket.
      * @covers \repository_s3bucket

diff --git a/tests/form_test.php b/tests/form_test.php
@@ -27,7 +27,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 global $CFG;
-require_once($CFG->libdir. '/formslib.php');
+require_once($CFG->libdir . '/formslib.php');
 require_once($CFG->dirroot . '/repository/lib.php');
 require_once($CFG->dirroot . '/repository/s3bucket/lib.php');
 
@@ -40,7 +40,6 @@
  * @coversDefaultClass \repository_s3bucket
  */
 final class form_test extends \advanced_testcase {
-
     /** @var int repo */
     protected $repo;
 

diff --git a/tests/generator/lib.php b/tests/generator/lib.php
@@ -30,7 +30,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class repository_s3bucket_generator extends testing_repository_generator {
-
     /**
      * Fill in type record defaults.
      *

diff --git a/tests/generator_test.php b/tests/generator_test.php
@@ -31,7 +31,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 final class generator_test extends \advanced_testcase {
-
     /**
      * Create type and instance.
      */

diff --git a/tests/mock_test.php b/tests/mock_test.php
@@ -41,7 +41,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 final class mock_test extends \advanced_testcase {
-
     /**
      * Create type and instance.
      */
@@ -105,7 +104,7 @@ public function test_listobjects(): void {
             ->setMethods(['getObject'])
             ->setConstructorArgs(['key', 'secret'])
             ->getMock();
-        $client->expects( $this->once())
+        $client->expects($this->once())
             ->method('getObject')
             ->with(['Bucket' => 'testbucket', 'key' => 'key'])
             ->will($this->returnValue([]));

diff --git a/tests/other_test.php b/tests/other_test.php
@@ -26,7 +26,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 global $CFG;
-require_once($CFG->libdir. '/formslib.php');
+require_once($CFG->libdir . '/formslib.php');
 require_once($CFG->dirroot . '/repository/lib.php');
 require_once($CFG->dirroot . '/repository/s3bucket/lib.php');
 
@@ -38,7 +38,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 final class other_test extends \advanced_testcase {
-
     /** @var int repo */
     protected $repo;
 

diff --git a/tests/privacy/privacy_test.php b/tests/privacy/privacy_test.php
@@ -34,7 +34,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 final class privacy_test extends provider_testcase {
-
     /**
      * Test privacy.
      * @covers \repository_s3bucket\privacy\provider