Skip to content

Feature python interface #66

Feature python interface

Feature python interface #66

Triggered via pull request September 18, 2024 17:37
Status Failure
Total duration 3m 50s
Artifacts

cpp-linter.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 10 warnings
cpp-linter
Process completed with exit code 1.
nuTens/propagator/const-density-solver.hpp:83:10 [clang-diagnostic-inconsistent-missing-override]: nuTens/propagator/const-density-solver.hpp#L83
'calculateEigenvalues' overrides a member function but is not marked 'override'
nuTens/tensors/tensor.hpp:57:5 [cppcoreguidelines-pro-type-member-init]: nuTens/tensors/tensor.hpp#L57
constructor does not initialize these fields: _dType, _device
nuTens/tensors/tensor.hpp:57:5 [modernize-use-equals-default]: nuTens/tensors/tensor.hpp#L57
use '= default' to define a trivial default constructor
nuTens/tensors/tensor.hpp:381:19 [performance-unnecessary-value-param]: nuTens/tensors/tensor.hpp#L381
parameter 'tensor' is passed by value and only copied once; consider moving it to avoid unnecessary copies
nuTens/tensors/tensor.hpp:388:5 [modernize-use-nodiscard]: nuTens/tensors/tensor.hpp#L388
function 'convertIndices' should be marked [[nodiscard]]
nuTens/tensors/tensor.hpp:404:5 [modernize-use-nodiscard]: nuTens/tensors/tensor.hpp#L404
function 'convertIndices' should be marked [[nodiscard]]
nuTens/tensors/torch-tensor.cpp:9:35 [performance-unnecessary-value-param]: nuTens/tensors/torch-tensor.cpp#L9
the parameter 'values' is copied for each invocation but only used as a const reference; consider making it a const reference
python/pyNuTens.cpp:17:29 [readability-named-parameter]: python/pyNuTens.cpp#L17
all parameters should be named in a function