-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature improve doxygen #36
Conversation
…t so logo now shows up in doxygen html and not just as a hue bold html command, add some more documentation to the instrumentation header
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
Cpp-Linter Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpp-linter Review
No concerns from clang-format.
Only 2 out of 4 clang-tidy concerns fit within this pull request's diff.
Click here for the full clang-tidy patch
diff --git a/nuTens/propagator/const-density-solver.hpp b/nuTens/propagator/const-density-solver.hpp
index 5df83a9..bb411cf 100644
--- a/nuTens/propagator/const-density-solver.hpp
+++ b/nuTens/propagator/const-density-solver.hpp
@@ -83 +83 @@ class ConstDensityMatterSolver : public BaseMatterSolver
- void calculateEigenvalues(const Tensor &energies, Tensor &eigenvectors, Tensor &eigenvalues);
+ void calculateEigenvalues(const Tensor &energies, Tensor &eigenvectors, Tensor &eigenvalues) override;
Have any feedback or feature suggestions? Share it here.
@@ -120,18 +166,21 @@ class ProfileWriter | |||
}; | |||
|
|||
class InstrumentationTimer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostic
nuTens/instrumentation.hpp:168:7: warning: [cppcoreguidelines-special-member-functions]
class 'InstrumentationTimer' defines a non-default destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
class InstrumentationTimer
^
@@ -13,6 +13,11 @@ | |||
#include <torch/torch.h> | |||
#endif | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostic
nuTens/tensors/tensor.hpp:15:7: warning: [bugprone-forward-declaration-namespace]
no definition found for 'Tensor', but a definition with the same name 'Tensor' found in another namespace '(global)'
class Tensor;
^
/home/runner/work/nuTens/nuTens/nuTens/tensors/tensor.hpp:21:7: note: a definition of 'Tensor' is found here
class Tensor
^
No description provided.