Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature improve doxygen #36

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Feature improve doxygen #36

merged 2 commits into from
Aug 2, 2024

Conversation

ewanwm
Copy link
Owner

@ewanwm ewanwm commented Aug 2, 2024

No description provided.

ewanwm added 2 commits August 2, 2024 05:52
…t so logo now shows up in doxygen html and not just as a hue bold html command, add some more documentation to the instrumentation header
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
nuTens/propagator/const-density-solver.cpp 100.00% <ø> (ø)
nuTens/propagator/const-density-solver.hpp 92.30% <100.00%> (ø)
nuTens/propagator/propagator.cpp 72.22% <ø> (ø)
nuTens/propagator/propagator.hpp 42.85% <ø> (ø)
nuTens/tensors/tensor.hpp 87.50% <ø> (ø)
nuTens/tensors/torch-tensor.cpp 64.19% <ø> (ø)
tests/tensor-basic.cpp 92.98% <ø> (ø)
tests/two-flavour-const-matter.cpp 100.00% <ø> (ø)
tests/two-flavour-vacuum.cpp 100.00% <ø> (ø)

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy reports: 2 concern(s)
  • nuTens/instrumentation.hpp:168:7: warning: [cppcoreguidelines-special-member-functions]

    class 'InstrumentationTimer' defines a non-default destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator

    class InstrumentationTimer
          ^
  • nuTens/propagator/const-density-solver.hpp:83:10: warning: [clang-diagnostic-inconsistent-missing-override]

    'calculateEigenvalues' overrides a member function but is not marked 'override'

        void calculateEigenvalues(const Tensor &energies, Tensor &eigenvectors, Tensor &eigenvalues);
             ^
    /home/runner/work/nuTens/nuTens/nuTens/propagator/base-matter-solver.hpp:20:18: note: overridden virtual function is here
        virtual void calculateEigenvalues(const Tensor &energies, Tensor &eigenvectors, Tensor &eigenvalues) = 0;
                     ^
    /home/runner/work/nuTens/nuTens/nuTens/propagator/const-density-solver.hpp:83:10: warning: annotate this function with 'override' or (rarely) 'final' [cppcoreguidelines-explicit-virtual-functions,modernize-use-override]
        void calculateEigenvalues(const Tensor &energies, Tensor &eigenvectors, Tensor &eigenvalues);
             ^
                                                                                                     override

Have any feedback or feature suggestions? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

No concerns from clang-format.
Only 2 out of 4 clang-tidy concerns fit within this pull request's diff.

Click here for the full clang-tidy patch
diff --git a/nuTens/propagator/const-density-solver.hpp b/nuTens/propagator/const-density-solver.hpp
index 5df83a9..bb411cf 100644
--- a/nuTens/propagator/const-density-solver.hpp
+++ b/nuTens/propagator/const-density-solver.hpp
@@ -83 +83 @@ class ConstDensityMatterSolver : public BaseMatterSolver
-    void calculateEigenvalues(const Tensor &energies, Tensor &eigenvectors, Tensor &eigenvalues);
+    void calculateEigenvalues(const Tensor &energies, Tensor &eigenvectors, Tensor &eigenvalues) override;

Have any feedback or feature suggestions? Share it here.

@@ -120,18 +166,21 @@ class ProfileWriter
};

class InstrumentationTimer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostic

nuTens/instrumentation.hpp:168:7: warning: [cppcoreguidelines-special-member-functions]

class 'InstrumentationTimer' defines a non-default destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator

class InstrumentationTimer
      ^

@@ -13,6 +13,11 @@
#include <torch/torch.h>
#endif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostic

nuTens/tensors/tensor.hpp:15:7: warning: [bugprone-forward-declaration-namespace]

no definition found for 'Tensor', but a definition with the same name 'Tensor' found in another namespace '(global)'

class Tensor;
      ^
/home/runner/work/nuTens/nuTens/nuTens/tensors/tensor.hpp:21:7: note: a definition of 'Tensor' is found here
class Tensor
      ^

@ewanwm ewanwm merged commit be4f82b into main Aug 2, 2024
1 of 2 checks passed
@ewanwm ewanwm deleted the feature_improve_doxygen branch August 2, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants