ZooKeeperNet: SaslAuthenticated events, robustness fixes, and tests #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Great! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ewhauser,
This is a follow-up to #38 which adds a few missing pieces and tightens a few knots.
Besides the addition of
SaslAuthenticatedevents and fixes, which should probably go in, I have a question:The SASL tests now use a much shorter session timeout than the others; 10s, down from 10000s, to avoid tests spinning "forever" in
Disposeon failure. But I'm now wondering: is that large timeout intentional—or just a mix-up between milliseconds and seconds? (They've been there for a long time; the history does not make it entirely obvious.)What do you think?
Cheers, -D