chore(lint): install html lint to lint njk and html files, remo…
#1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve `lint-space`
ala-n
reviewed
Feb 21, 2023
pages/views/search.njk
Outdated
| @@ -6,6 +6,6 @@ eleventyExcludeFromCollections: true | |||
| collectionIcon: sidebar/search.svg | |||
| --- | |||
| <esl-d-search-page-wrapper> | |||
| <div class="animation-loading bg-blue m-auto"></div> | |||
| <div class="gcse-search" data-resultsUrl="{{ '/search.html' | url }}"></div> | |||
| <div class="animation-loading bg-blue m-auto"></div> | |||
There was a problem hiding this comment.
As far as it is looked, it is incorrect. There should be two spaces instead of three
ala-n
requested changes
Feb 21, 2023
pages/views/examples/toggleable.njk
Outdated
Comment on lines
9
to
14
| components: | ||
| - esl-toggleable | ||
| - esl-trigger | ||
| examples: | ||
| - accordion | ||
| - tabs |
There was a problem hiding this comment.
That's will not work.
Frontmetter it is yml syntax, so each indent matters.
So it is not right configuration here right now
ala-n
force-pushed
the
main
branch
6 times, most recently
from
1f18a8a
to
6506db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1409