test(e2e): handle sanpshot's size mismatch #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fshovchko
requested review from
dshovchko,
yadamskaya and
abarmina
and removed request for
a team
ala-n
approved these changes
Oct 17, 2024
ala-n
reviewed
Oct 17, 2024
Comment on lines
+47
to
+50
| top: Math.floor(padY), | ||
| bottom: Math.ceil(padY), | ||
| left: Math.floor(padX), | ||
| right: Math.ceil(padX), |
| const targetWidth = Math.max(metadata1.width!, metadata2.width!); | ||
| const targetHeight = Math.max(metadata1.height!, metadata2.height!); | ||
|
|
||
| const padImage = async ( |
There was a problem hiding this comment.
Separate method instead of anonymous function
|
🎉 This PR is included in version 5.0.0-beta.37 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After test run of a new snapshot matcher implementation, it was discovered that reports became less informative.
The most important things are: