Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(esl-media): e2e testing #2725

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test(esl-media): e2e testing #2725

wants to merge 5 commits into from

Conversation

fshovchko
Copy link
Contributor

Closes: #2709

@ala-n, do we need any other functionality tested or basic check for video/iframe tag is enough?

@fshovchko fshovchko added the e2e label Oct 28, 2024
@fshovchko fshovchko requested a review from a team October 28, 2024 19:55
@fshovchko fshovchko self-assigned this Oct 28, 2024
@fshovchko fshovchko requested review from dshovchko, yadamskaya and NastaLeo and removed request for a team October 28, 2024 19:55
@ala-n
Copy link
Collaborator

ala-n commented Oct 29, 2024

Nope, checking the existence of an iframe is not enough.
From what I could suggest based on YouTube provider work we need:

  1. Check that YouTube API is loaded, check that it is loaded once
  2. We need to check the inner iframe is, actually, a YouTube and that it at least contains an ID of the required video
  3. We need to check initial attributes as well (playsinline, autoplay, mute)
  4. Ideally we need as much as possible including the ability to play etc. but unfortunately, YouTube no longer allows playing videos for unauthorized users (autotests including).

e2e/tests/modules/esl-media/utils/wait.ts Outdated Show resolved Hide resolved
e2e/tests/modules/esl-media/utils/utils.ts Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Oct 31, 2024

Code Climate has analyzed commit 1f1dc61 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 65.3% (0.0% change).

View more on Code Climate.

@fshovchko fshovchko requested a review from ala-n October 31, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[⚡tests ]: make sure YouTube/HTML5 ESLMedia provides are covered by tests
2 participants