chore(site): add share example #2748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadamskaya
added
site
yadamskaya
requested review from
dshovchko,
ala-n and
fshovchko
and removed request for
a team
|
All contributors have signed the CLA ✍️ ✅ |
|
Code Climate has analyzed commit f08c5a6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 65.3% (0.0% change). View more on Code Climate. |
abarmina
reviewed
Nov 14, 2024
site/views/examples/share.njk
Outdated
| <p>Example of share button with default icon rendering.</p> | ||
| <esl-share-button name="linkedin" default-icon></esl-share-button> | ||
| <hr> | ||
| <script type="text/html" |
There was a problem hiding this comment.
maybe we can merge this with the previous tab? call it "Share button" and add the example without the icon that was there before? leave all 4 examples
There was a problem hiding this comment.
@abarmina I like this idea, thanks
ala-n
added
not ready for merge
and removed
needs review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESL Share component has been migrated to UI Playground
@exadel-inc/esl-core-team please let me know if any additional component usage examples I need to add
Closes: #2154