fix(core): rework refresh animation and behaviour (embedded async flow) + remove redundant normalization for HTML #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w) + remove redundant normalization for HTML
yadamskaya
approved these changes
Apr 4, 2024
dshovchko
approved these changes
Apr 4, 2024
|
|
||
| afterNextRender(() => this.$container.style.minHeight = '0px'); | ||
| skipOneRender(() => { | ||
| this.$container.style.minHeight = '0px'; |
There was a problem hiding this comment.
Suggested change
| this.$container.style.minHeight = '0px'; | |
| this.$container.style.minHeight = '0'; |
There was a problem hiding this comment.
Added to #705 as well (not sure if that redundant or was left due to animation problem)
abarmina
approved these changes
Apr 4, 2024
NastaLeo
approved these changes
Apr 4, 2024
|
🎉 This PR is included in version 2.1.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.