Skip to content

Commit

Permalink
#54: Remove dependencies from JAR (#55)
Browse files Browse the repository at this point in the history
  • Loading branch information
kaklakariada authored Dec 6, 2023
1 parent 7f53cc7 commit c016504
Show file tree
Hide file tree
Showing 11 changed files with 131 additions and 129 deletions.
19 changes: 10 additions & 9 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
*.sh text eol=lf

.github/workflows/release_droid_upload_github_release_assets.yml linguist-generated=true
.github/workflows/release_droid_prepare_original_checksum.yml linguist-generated=true
.github/workflows/release_droid_print_quick_checksum.yml linguist-generated=true
.github/workflows/ci-build-next-java.yml linguist-generated=true
.github/workflows/broken_links_checker.yml linguist-generated=true
.github/workflows/dependencies_check.yml linguist-generated=true
.settings/org.eclipse.jdt.core.prefs linguist-generated=true
dependencies.md linguist-generated=true
pk_generated_parent.pom linguist-generated=true
doc/changes/changelog.md linguist-generated=true
.github/workflows/release_droid_prepare_original_checksum.yml linguist-generated=true
.github/workflows/release_droid_print_quick_checksum.yml linguist-generated=true
.github/workflows/ci-build.yml linguist-generated=true
.github/workflows/ci-build-next-java.yml linguist-generated=true
.github/workflows/broken_links_checker.yml linguist-generated=true
.github/workflows/dependencies_check.yml linguist-generated=true
.settings/org.eclipse.jdt.core.prefs linguist-generated=true
dependencies.md linguist-generated=true
pk_generated_parent.pom linguist-generated=true
doc/changes/changelog.md linguist-generated=true
29 changes: 29 additions & 0 deletions .github/workflows/ci-build-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: CI Build Scala Linter
on:
push:
branches:
- main
pull_request:

jobs:
scala-linter:
runs-on: ubuntu-latest
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Checkout the repository
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Set up JDK 11
uses: actions/setup-java@v4
with:
distribution: "temurin"
java-version: 11
cache: "maven"
- name: Run scalafix linting
run: |
mvn --batch-mode clean compile test scalafix:scalafix \
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
-DtrimStackTrace=false
33 changes: 18 additions & 15 deletions .github/workflows/ci-build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions .github/workflows/release_droid_release_on_maven_central.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Set up Maven Central Repository
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: 'temurin'
distribution: "temurin"
java-version: 11
cache: 'maven'
cache: "maven"
server-id: ossrh
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD
Expand All @@ -33,4 +33,4 @@ jobs:
MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }}
- name: Remove release pom file
run: rm -rf release-pom.xml
run: rm -rf release-pom.xml
2 changes: 0 additions & 2 deletions .project-keeper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@ sources:
modules:
- maven_central
linkReplacements:
- "LICENSE-exasol-script-api.txt|https://mit-license.org/"
- "https://github.com/google/guava/guava|https://github.com/google/guava"
- "http://wiki.fasterxml.com/JacksonModuleScala|https://github.com/FasterXML/jackson-module-scala"
- "http://nexus.sonatype.org/oss-repository-hosting.html|https://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin"
- "http://nexus.sonatype.org/oss-repository-hosting.html/scalatest-maven-plugin|https://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin"
excludes:
- "E-PK-CORE-18: Outdated content: '.github/workflows/ci-build.yml'"
- "E-PK-CORE-18: Outdated content: '.github/workflows/release_droid_release_on_maven_central.yml'"
90 changes: 44 additions & 46 deletions dependencies.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions doc/changes/changelog.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions doc/changes/changes_2.0.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Import Export UDF Common Scala 2.0.0, released 2023-12-06

Code name: Remove dependencies from JAR

## Summary

Previous releases of this project contained all dependencies in the published JAR file (i.e. fat JAR). This project is a library that is used in other projects and should not contain dependencies in the JAR, so we removed them.

## Bugfixes

* #54: Removed dependencies from published JAR

## Dependency Updates

### Plugin Dependency Updates

* Updated `com.exasol:project-keeper-maven-plugin:2.9.16` to `2.9.17`
* Removed `org.apache.maven.plugins:maven-assembly-plugin:3.5.0`
* Updated `org.codehaus.mojo:versions-maven-plugin:2.16.1` to `2.16.2`
4 changes: 2 additions & 2 deletions pk_generated_parent.pom

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 3 additions & 28 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<artifactId>import-export-udf-common-scala</artifactId>
<version>1.1.2</version>
<version>2.0.0</version>
<name>Import Export UDF Common Scala</name>
<description>Common import export libraries used in Exasol user defined functions</description>
<url>https://github.com/exasol/import-export-udf-common-scala/</url>
<parent>
<artifactId>import-export-udf-common-scala-generated-parent</artifactId>
<groupId>com.exasol</groupId>
<version>1.1.2</version>
<version>2.0.0</version>
<relativePath>pk_generated_parent.pom</relativePath>
</parent>
<properties>
Expand Down Expand Up @@ -229,31 +229,6 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<version>3.5.0</version>
<configuration>
<descriptors>
<descriptor>src/assembly/all-dependencies.xml</descriptor>
</descriptors>
<appendAssemblyId>false</appendAssemblyId>
<archive>
<manifest>
<addClasspath>true</addClasspath>
</manifest>
</archive>
</configuration>
<executions>
<execution>
<id>make-assembly</id>
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.itsallcode</groupId>
<artifactId>openfasttrace-maven-plugin</artifactId>
Expand All @@ -275,7 +250,7 @@
<plugin>
<groupId>com.exasol</groupId>
<artifactId>project-keeper-maven-plugin</artifactId>
<version>2.9.16</version>
<version>2.9.17</version>
<executions>
<execution>
<goals>
Expand Down
22 changes: 0 additions & 22 deletions src/assembly/all-dependencies.xml

This file was deleted.

0 comments on commit c016504

Please sign in to comment.