Added text ai wrapper interface #166
Conversation
MarleneKress79789
requested a deployment
to
manual-approval
GitHub Actions
Waiting
| language_alias: str = LANGUAGE_ALIAS, | ||
| run_deploy_container: bool = True, | ||
| run_deploy_scripts: bool = True, | ||
| run_upload_models: bool = True, |
There was a problem hiding this comment.
We don't have scripts to deploy. Neither do we have any models to upload upfront.
But we probably need the BucketFS credentials and HF token, just like the TE.
There was a problem hiding this comment.
yes but we plan on having scripts and default models in the future, and want to prevent having to change the interface to often.
i am not sure about the HF token. that one is for private models, and i doubt we will have private models as default models for text ai, which are the only ones this installer will use. @tkilias what do you think?
Bucketfs credential you might be right. i thought those would be given through the secret store? is this not the case?
There was a problem hiding this comment.
With regards to the private token, as far as I am concerned, there is no difference between the Text AI and TE.
There was a problem hiding this comment.
User might use private models, so the token is needed
There was a problem hiding this comment.
Regarding bucketfs credentials that comes from the AI Lab config
There was a problem hiding this comment.
We will have scripts and default models. Scripts will be added in Q2 in form of span functions and default models, we actually will need already this quarter.
There was a problem hiding this comment.
having the HF token here still seems kinda iffy to me. this call does not need them. unless we allow users to set default model? which seem not default then.
otherwise if people want to install additional private models, should that not happen via a different call, which then can also be used to set the token?
There was a problem hiding this comment.
we can also remove the hf token, have no strong feelings about it
| pass | ||
|
|
||
| def initialize_text_ai_extension(conf: Secrets, | ||
| container_file: Path, |
There was a problem hiding this comment.
Maybe make container file and version optional, this way we easily can switch between them
MarleneKress79789
requested a deployment
to
manual-approval
GitHub Actions
Waiting
fixes #164