#271: Implemented checking SCS content for completeness and correctness #272
Conversation
ckunki
requested a deployment
to
manual-approval
GitHub Actions
Waiting
|
|
||
| def verify_connection(scs: Secrets) -> int: | ||
| if BackendSelector(scs).use_itde: | ||
| # Question: Is it OK, to let bring_itde_up modify the SCS content, here? |
There was a problem hiding this comment.
Is it OK, to let bring_itde_up() modify the SCS content, here?
There was a problem hiding this comment.
Additional question:
- Should the command line really launch the IDTE only for verifying the connection parameters?
- As actually the ITDE does not require actual connection parameters but only offers optional(!) configuration of disk and mem size.
There was a problem hiding this comment.
Also, we need to bring the ITDE up and take it down, in a try .. finally manner.
There was a problem hiding this comment.
I updated the docstring.
But the question regarding the ITDE is still pending.
ckunki
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ckunki
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ckunki
requested a deployment
to
manual-approval
GitHub Actions
Waiting
| def check(self): | ||
| """ | ||
| Check if the content of the SCS is complete wrt. the selected | ||
| backend as the required options depend on the selected backend. |
There was a problem hiding this comment.
Please say that the function raises the ScsCliError if the check fails. I have to look at the code to figure this out.
There was a problem hiding this comment.
Thanks.
Please see next push updating the docstring.
| def get_option_set(scs_file: Path) -> OptionSet: | ||
| """ | ||
| Return an instance of an OptionSet if the SCS contains a proper | ||
| backend selection. Otherwise report an error and return None. |
There was a problem hiding this comment.
Please update the docstring according to your latest changes.
| @add_params(SCS_OPTIONS) | ||
| @click.option( | ||
| "--connect/--no-connect", | ||
| is_flag=True, |
There was a problem hiding this comment.
Can we make the default depend on the backend?
For a DB that is already running it would be a good idea to check that the configuration works. However, for the Docker DB it's a different story. On one hand, starting it up takes time. On the other hand, all you need to check is that the memory parameters are with reasonable range. If we can't start the ITDE it must be for some unrelated reason.
There was a problem hiding this comment.
I very much agree on your statements.
So what should we do then?
Not verify Docker DB?
There was a problem hiding this comment.
I would make the default = False for the DockerDB and True otherwise. Maybe slightly awkward to implement, but not too difficult.
ckunki
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Closes #271