Skip to content

Commit

Permalink
Fixed an issue where IE11 would submit null for line and column numbers
Browse files Browse the repository at this point in the history
  • Loading branch information
niemyjski committed Jun 8, 2015
1 parent eba0020 commit 8c51797
Show file tree
Hide file tree
Showing 8 changed files with 1,163 additions and 1,163 deletions.
2,306 changes: 1,153 additions & 1,153 deletions dist/exceptionless.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/exceptionless.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/exceptionless.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/exceptionless.min.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/exceptionless.node.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/exceptionless.node.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/services/DefaultErrorParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ export class DefaultErrorParser implements IErrorParser {
name: (frame.func || ANONYMOUS).replace('?', ANONYMOUS),
parameters: getParameters(frame.args),
file_name: frame.url,
line_number: frame.line,
column: frame.column
line_number: frame.line || 0,
column: frame.column || 0
});
}

Expand Down
4 changes: 2 additions & 2 deletions src/services/NodeErrorParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export class NodeErrorParser implements IErrorParser {
name: frame.getMethodName() || frame.getFunctionName(),
//parameters: frame.args,
file_name: frame.getFileName(),
line_number: frame.getLineNumber(),
column: frame.getColumnNumber(),
line_number: frame.getLineNumber() || 0,
column: frame.getColumnNumber() || 0,
declaring_type: frame.getTypeName(),
data: {
is_native: frame.isNative() || (!!frame.filename && frame.filename[0] !== '/' && frame.filename[0] !== '.')
Expand Down

0 comments on commit 8c51797

Please sign in to comment.