Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve tampering test on exercise "Authentication System" #2193

Merged
merged 4 commits into from
Oct 19, 2023
Merged

feat: improve tampering test on exercise "Authentication System" #2193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
918bcb2
build(deps): bump actions/checkout from 4.1.0 to 4.1.1 (#2192)
dependabot[bot] Oct 18, 2023
67e7c8f
Merge branch 'main' of https://github.com/salvatore-piccione/csharp
Oct 19, 2023
a61a6f8
feat: improve tampering test on exercise "Authentication System"
salvatore-piccione Oct 18, 2023
04151e3
feat: improve test readability
Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/concept/authentication-system/.meta/Exemplar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public Identity Admin
get { return new Identity { Email = admin.Email, EyeColor = admin.EyeColor }; }
}

public IReadOnlyDictionary<string, Identity> GetDevelopers()
public IDictionary<string, Identity> GetDevelopers()
{
return new ReadOnlyDictionary<string, Identity>(developers);
}
Expand Down
23 changes: 23 additions & 0 deletions exercises/concept/authentication-system/AuthenticationSystemTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,18 @@ public void GetAdmin()
Assert.Equal(admin, authenticator.Admin);
}

[Fact]
[Task(4)]
public void CheckAdminCannotBeTampered()
{
var adminEmail = "admin@ex.ism";
var admin = new Identity { EyeColor = "green", Email = adminEmail };
var authenticator = new Authenticator(admin);
var tamperedAdmin = authenticator.Admin;
tamperedAdmin.Email = "admin@hack.ed";
Assert.Equal(adminEmail, authenticator.Admin.Email);
}

[Fact]
[Task(5)]
public void GetDevelopers()
Expand All @@ -24,4 +36,15 @@ public void GetDevelopers()
bool?[] expected = { true, true, true };
Assert.Equal(expected, actual);
}

[Fact]
[Task(5)]
public void CheckDevelopersCannotBeTampered()
{
var authenticator = new Authenticator(new Identity { EyeColor = "green", Email = "admin@ex.ism" });
IDictionary<string, Identity> devs = authenticator.GetDevelopers();

Identity tamperedDev = new Identity { EyeColor = "grey", Email = "anders@hack.ed" };
Assert.Throws<NotSupportedException>(() => devs["Anders"] = tamperedDev);
}
}
Loading