Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync triangle and add stub #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BNAndras
Copy link
Member

This syncs the docs, metadata, and tests for triangle. This adds two tests for scalene triangles that check other combinations of the two sides being equal. I also added an non-compiling stub that gives the student the minimum interface needed to pass the tests.

After this, there are 37 exercises where configlet is reporting one or more tests missing since the test.toml files were last updated.

@BNAndras BNAndras added the x:rep/tiny Tiny amount of reputation label Jan 26, 2025
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat.


implementation
// Provide your implementation here
end.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
end.
end.

Last line is exceptional with a missing EOL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other files in this repo don’t end with a blank line though so the file is fine as written.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not been vigilant enough, then. Just because the others are wrong, doesn't mean that we should not fix that. ;)

Copy link
Member

@kotp kotp Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a text file, as such it should be consistent with its termination of lines. Otherise I have to check and fix it when I concatenate information later. (Headings end up being trailing the last "line" of a file when the last "line" ends with EOL plus more characters.) Or I have to check on the rendering for something I really should not have to check for.

@BNAndras
Copy link
Member Author

Embarcadero is now coming after me for a licensing issue related to my Exercism work. Therefore, this is my final contribution involving Delphi Pascal code.

@rpottsoh
Copy link
Member

Licensing issue related to Exercism?

@BNAndras
Copy link
Member Author

Indirectly. It’s related to a Delphi 11 Community Edition license I obtained two years ago when I was first taking a look at Delphi Pascal track here.

@rpottsoh
Copy link
Member

@BNAndras unless you are profiting by the CE license I don't see what the issue would be as it relates to Exercism and the Delphi track specifically. At any rate, thanks for the work you have put in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/tiny Tiny amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants