Increase Go test runner timeout to 30 seconds #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the Go test runner is usually very fast, some exercises benefit from running the tests with the race detector enabled. This can increase significantly the time tests take to run, and this increase in timeout is aimed at those exercises.
Currently, exercises with the race detector enabled are having timeouts regularly, while sometimes they pass. Adding 10 seconds to the default timeout of 20 seconds should make those tests pass more consistently.
For more context, see: http://forum.exercism.org/t/bank-account-potential-bug/8326/14
Also reported in the test runner repo: exercism/go-test-runner#111