-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rotational-cipher exercise #73
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Four trivial suggestions:
|
I've just pushed a commit to fix to the fork repo, although I notice the commit or changes hasn't appeared here. Can this PR be reopened? |
- Mark second to last tests xtest - Remove unnecessary exp import - Use global constants for "A", "Z", "a" and "z" - Add instructions.append.md
With extra commits, they appear when the PR is reopened. LGTM (Once I rebased with a closed PR instead of adding extra commits, that messed things up and the PR couldn't be reopened.) |
@keiravillekode Could you re-review? |
rotational-cipher for Nibbly November