Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mentoring.md #2345

Closed
wants to merge 2 commits into from
Closed

Update mentoring.md #2345

wants to merge 2 commits into from

Conversation

thomasantony12
Copy link
Contributor

Changed some words and grammatical mistakes

Changed some words and grammatical mistakes
@github-actions github-actions bot added track/python Python track type/mentor-notes Mentor notes labels Jun 7, 2024
tracks/python/exercises/perfect-numbers/mentoring.md Outdated Show resolved Hide resolved
Note this first creates a `list` of factors in memory by iterating over the entire range, then iterates once more over the `list` to `sum()` its values.
This is inefficent for both memory and processing time.
Dropping the `[]` drops `list` creation and allows `sum()` to lazily process a `generator expression`, wich only requires a single iteration and a smaller memory footprint.
Note that this first creates a `list` of factors in memory by iterating over the entire range, then iterating its values once more over the `list` to `sum()`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original version of this line is correct as-is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to original version.

Changes are made
@thomasantony12 thomasantony12 closed this by deleting the head repository Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track/python Python track type/mentor-notes Mentor notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants