chore: implement init containers for dynamic configuration generation… #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… across multiple components
…ployment templates
linuxluigi
requested changes
Dec 9, 2025
…used RabbitMQ configmap
linuxluigi
approved these changes
Dec 9, 2025
linuxluigi
requested changes
Dec 9, 2025
Contributor
linuxluigi
left a comment
linuxluigi
left a comment
There was a problem hiding this comment.
env vars for DB & MQ still in use for hostanme
linuxluigi
requested changes
Dec 9, 2025
linuxluigi
requested changes
Dec 10, 2025
Contributor
linuxluigi
left a comment
linuxluigi
left a comment
There was a problem hiding this comment.
Self-manage JQ image need to be implement
linuxluigi
requested changes
Dec 18, 2025
Contributor
|
JQ image need to be added in 
|
…r secrets and refactor config generator references
xiangyisss
force-pushed
the
EXVT-6034
branch
from
10ba614 to
8adcca2
Compare
xiangyisss
force-pushed
the
EXVT-6034
branch
from
6f2702b to
7df761f
Compare
xiangyisss
force-pushed
the
EXVT-6034
branch
from
59781ec to
ec08569
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements an init container pattern for dynamic configuration generation in Kubernetes deployments. Instead of embedding sensitive credentials (database and RabbitMQ passwords) directly in ConfigMaps, the system now uses placeholders that are replaced at runtime by an init container using secrets.
Key changes:
- Introduced a new init container (
inject-secrets) that replaces credential placeholders in configuration templates with values from Kubernetes secrets - Updated all deployment manifests to use the new config injection pattern with template and generated volumes
- Changed default values for
postgresql.sslmodeandrabbitmq.vhostto non-empty defaults
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/exivity/values.yaml | Added configGenerator image settings and updated default values for postgresql.sslmode and rabbitmq.vhost |
| charts/exivity/values.schema.json | Added schema definition for configGenerator and updated default examples |
| charts/exivity/templates/_init_config_injector.tpl | New template defining the init container, volumes, and mounts for config injection |
| charts/exivity/templates/_config.tpl | Replaced hardcoded credentials with placeholder tokens |
| charts/exivity/templates/secret.yaml | Added new RabbitMQ secret resource |
| charts/exivity/templates/postgres-secret.yaml | Added POSTGRES_USER to secret data |
| charts/exivity/templates/pigeon/configmap.yaml | Replaced hardcoded credentials with placeholder tokens |
| charts/exivity/templates/use/deployment.yaml | Updated to use new config injection pattern and added secret checksums |
| charts/exivity/templates/transcript/deployment.yaml | Updated to use new config injection pattern and added secret checksums |
| charts/exivity/templates/proximity/migrate.yaml | Updated to use new config injection pattern and added secret checksums |
| charts/exivity/templates/proximity/cli.deployment.yaml | Updated to use new config injection pattern and added secret checksums |
| charts/exivity/templates/proximity/api.deployment.yaml | Updated to use new config injection pattern, split projected volume into separate volumes |
| charts/exivity/templates/pigeon/deployment.yaml | Updated to use new config injection pattern and added secret checksums |
| charts/exivity/templates/horizon/deployment.yaml | Updated to use new config injection pattern and added secret checksums |
| charts/exivity/templates/griffon/deployment.yaml | Updated to use new config injection pattern and added secret checksums |
| charts/exivity/templates/executor/deployment.yaml | Updated to use new config injection pattern and added secret checksums |
| charts/exivity/templates/edify/deployment.yaml | Updated to use new config injection pattern, split projected volume into separate volumes |
| charts/exivity/templates/dummy-data/job.yaml | Updated to use new config injection pattern and reorganized volume definitions |
| charts/exivity/templates/chronos/deployment.yaml | Updated to use new config injection pattern and added secret checksums |
| .github/workflows/image-release.yml | Added jq image to release workflow |
| .github/workflows/daily-release.yml | Added jq image to daily release workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…djust volume mounts in deployment templates
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…add rabbitmq secret manifest
linuxluigi
requested changes
Jan 5, 2026
Contributor
linuxluigi
left a comment
linuxluigi
left a comment
There was a problem hiding this comment.
Looks great. Let's run test on it and merge it 🚀
Contributor
|
Tests are done. The credentials working perfectly fine and there is no difference between the main branch on each container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new template for generating configuration files in init containers.
Updated deployment configurations to utilize the new init container for configuration generation.
Removed obsolete configmap templates for various components.
Adjusted volume mounts to accommodate the new configuration structure.
EXVT-6034