Skip to content

Comments

detailpost page不用login,評論須login#49

Open
zzpengg wants to merge 2 commits intoexma-square:developfrom
zzpengg:develop
Open

detailpost page不用login,評論須login#49
zzpengg wants to merge 2 commits intoexma-square:developfrom
zzpengg:develop

Conversation

@zzpengg
Copy link
Contributor

@zzpengg zzpengg commented Feb 12, 2017

2017-02-12 13-36-23

@IvanWei
Copy link
Contributor

IvanWei commented Feb 12, 2017

疑問

留言後跳出要求登入,預期的行為是

  1. 跳出登入的 Dialog 讓使用者登入
  2. 什麼事也沒有

其次登入後,原本打好的留言會被保留嗎?

@zzpengg
Copy link
Contributor Author

zzpengg commented Feb 12, 2017

現在是只有alert,其餘甚麼動作都沒有
登入後,會被轉向首頁,所以留言不會被保留

result = JSON.parse(JSON.stringify(result));
if(result.code != 200){
return alert(result.message);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L207 - L210 問題

  1. 打在這合適嗎?
  2. L207 用途是什麼?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

轉成json格式,為了要使用result.code & result.message

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

後端不是直接回傳 JSON 格式?

@IvanWei
Copy link
Contributor

IvanWei commented Feb 12, 2017

有沒有更好的處理方式?


目前我已經想到以下幾種問題:

  1. 登入後跳回首頁,使用者不一定能找得到原本想留言的文章
  2. 承上找到後,之前辛苦打的留言不見,這會導致網站使用者留言的慾望

試想自己是使用者碰到這樣的網站,你還會想留言嗎?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants