Open
Conversation
izetag
requested changes
Aug 7, 2025
| auto tls_client = io::TlsWrapper::StartTlsClient(std::move(client), {}, test_deadline); | ||
|
|
||
| char c = 0; | ||
| std::optional<size_t> read_bytes = tls_client.RecvAll(&c, 1, test_deadline); |
Collaborator
There was a problem hiding this comment.
RecvAll returns size_t, so no need in optional.
| @@ -595,6 +635,7 @@ bool TlsWrapper::WaitWriteable(Deadline deadline) { | |||
| return impl_->bio_data.socket.WaitWriteable(deadline); | |||
| } | |||
|
|
|||
| const char* context | ||
| ) { | ||
| UASSERT(ssl); | ||
| if (!len) return 0; |
Collaborator
There was a problem hiding this comment.
It breaks the contracts as it says optional{0} for connection ended
core/src/engine/io/tls_wrapper.cpp
Outdated
| if (!len) return 0; | ||
|
|
||
| char* const begin = static_cast<char*>(buf); | ||
| char* const end = begin + len; |
Collaborator
There was a problem hiding this comment.
It seems we use end only to calculate back the len. So it's better to use len directly
core/src/engine/io/tls_wrapper.cpp
Outdated
|
|
||
| bio_data.current_deadline = Deadline::Passed(); | ||
|
|
||
| const int io_ret = io_func(ssl.get(), begin, end - begin, &chunk_size); |
Collaborator
There was a problem hiding this comment.
If we restrict io_func to a specific signature, it's better to use pointer, not template
Collaborator
Author
There was a problem hiding this comment.
I implemented this in the manner of existing PerformSslIo and would change it for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.