-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add alertmanager client #82
Conversation
e251016
to
0e72839
Compare
a5a064e
to
b9cab81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach works for me as long as you take care of doing the PRs on all the artifacts that would need to replace the Riemann client with the Alert client.
Down the line, we should aim at having those concerns directly available in Mania which should basically provide a base system and configuration to which we'll be able to augment with a subsystem from the artifact we are creating. But we are not there yet.
I am not super happy with this being part of reporter personally (it was my undestanding it had to be). I would rather have it separate and depended upon in mania down the line as you suggest. Otherwise, yes, the ultimate goal is to get out of riemann on all artifacts. |
This is a bit more nuanced than this and I would say it's two efforts:
Regarding the short-term measure, it doesn't have to be implemented specially on
Then, on the consuming artifacts it would be just a matter of bumping mania and removing the reporter dependency. Maybe a bit more will be needed but you get the idea. As you may I guessed, we don't have a strong appetite to have a special library dedicated just to this. [1] : https://app.shortcut.com/exoscale/story/115506/orchestrators-alerting-strategy#activity-117365 |
closing in favor of https://github.com/exoscale/mania/pull/26 [wip] |
Adds simple alertmanager client with a default implementation using aleph for http transport.