chore: remove some wasm2 types for now

Signed-off-by: Henry Gressmann <mail@henrygressmann.de>
explodingcamera · Dec 5, 2023 · 7d2a0a7 · 7d2a0a7
1 parent 67adf21
commit 7d2a0a7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/crates/parser/src/conversion.rs b/crates/parser/src/conversion.rs
@@ -71,8 +71,16 @@ pub(crate) fn convert_blocktype(blocktype: &wasmparser::BlockType) -> BlockArgs
     use wasmparser::BlockType::*;
     match blocktype {
         Empty => BlockArgs::Empty,
+
+        // We should maybe have all this in a single variant for our custom bytecode
+
+        // TODO: maybe solve this differently so we can support 128-bit values
+        // without having to increase the size of the WasmValue enum
         Type(ty) => BlockArgs::Type(convert_valtype(ty)),
-        FuncType(ty) => BlockArgs::FuncType(*ty),
+
+        // Wasm 2.0
+        FuncType(_ty) => unimplemented!(),
+        // FuncType(ty) => BlockArgs::FuncType(*ty),
     }
 }
 

diff --git a/crates/types/src/instructions.rs b/crates/types/src/instructions.rs
@@ -4,7 +4,8 @@ use super::{FuncAddr, GlobalAddr, LabelAddr, LocalAddr, TableAddr, TypeAddr, Val
 pub enum BlockArgs {
     Empty,
     Type(ValType),
-    FuncType(u32),
+    // TODO: wasm 2.0
+    // FuncType(u32),
 }
 
 /// Represents a memory immediate in a WebAssembly memory instruction.