-
Notifications
You must be signed in to change notification settings - Fork 160
[eas-cli] improve eas config extension handling #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vonovak
wants to merge
3
commits into
main
Choose a base branch
from
vonovak/_eas-cli_fix_disabling_cache_when_extending_eas_config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[eas-cli] improve eas config extension handling #3143
vonovak
wants to merge
3
commits into
main
from
vonovak/_eas-cli_fix_disabling_cache_when_extending_eas_config
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
08216bc to
3152bc2
Compare
3152bc2 to
7e8a949
Compare
|
Size Change: -630 B (0%) Total Size: 53.6 MB
|
7e8a949 to
aa06e60
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
==========================================
+ Coverage 51.90% 51.92% +0.03%
==========================================
Files 616 616
Lines 24850 24861 +11
Branches 5225 5228 +3
==========================================
+ Hits 12895 12906 +11
Misses 10883 10883
Partials 1072 1072 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aa06e60 to
640cbb5
Compare
|
Subscribed to pull request
Generated by CodeMention |
kadikraman
reviewed
Aug 13, 2025
Co-authored-by: Kadi Kraman <kadi@expo.io>
|
✅ Thank you for adding the changelog entry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Why
This PR fixes an issue with profile extension in EAS JSON configuration. Previously, when a build profile extended a base profile that contained platform-specific settings, there was no handling for overriding these settings on the common level. For example, given
eas.json:What should the resulting
prebuildCommandbe forextension1? Well, we didn't handle this scenario - these kinds of overrides were ignored.It's probably quite unlikely that people will override random commands like this, but I happened to run into this problem when overriding the
cachefield: I was attempting to disable cache which was defined inbaseonly for ios, but marking it asdisabled: truein an extending workflow was ignored.I fixed that in the first commit because I feel it's reasonable to want to disable a cache.
But then the question arises, what about overriding other entries like in the example above? I think it doesn't make sense to support this for all values, and in the second commit, I throw an error when user attempts to do that.
Up for for discussion whether this is best.
How
packages/eas-json/src/build/resolver.tsTest Plan
Added several test cases to verify the behavior.