Fix #476: Resolve React 19 stack overflow caused by deepmerging children props#485
Open
lifedraft wants to merge 9 commits intoexpress-labs:masterfrom
Open
Fix #476: Resolve React 19 stack overflow caused by deepmerging children props#485lifedraft wants to merge 9 commits intoexpress-labs:masterfrom
lifedraft wants to merge 9 commits intoexpress-labs:masterfrom
Conversation
added 9 commits
June 2, 2025 08:34
|
Any updates to this PR? I used this with an older version, we're migrating to the Next 15, so it would benefit us really much? I am more than happy to help with anything needed. |
which-sam
added a commit
to whichdigital/pure-react-carousel
that referenced
this pull request
Oct 30, 2025
- Add safeArrayMerge and safeMergeOptions to prevent circular references - Update Store.jsx to use safeMergeOptions in deepMerge operations - Fix WithStore.jsx to separate children props to avoid React 19 warnings - Enhance Slider.jsx prop filtering to prevent DOM attribute warnings - Update objectMerge.js to support custom merge functions and array merging - Add comprehensive tests for safe merge functionality Resolves React 19 stack overflow issues caused by deepmerging children props. Implements changes from express-labs#485 for full React 19 support. BREAKING CHANGE: None - maintains backward compatibility with React 15-18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fix stack overflow error in React 19 caused by deepmerge attempting to merge children props. Fixes: #476
Why:
The library was crashing with "RangeError: Maximum call stack size exceeded" when used with Next.js 15 and React 19. This occurred because the
WithStoreHOC was trying to deepmergethis.props.children, which contains React elements with circular references that cause infinite recursion during the merge process.How:
Modified the
render()method inWithStore.jsxto extractchildrenfrom props before passing the remaining props todeepMerge. The children are then passed directly to the wrapped component, avoiding the circular reference issue while maintaining the same functionality.Checklist: