Skip to content

trying to fix component types #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrbinky3000 merged 1 commit into from
Dec 24, 2025
Merged

trying to fix component types #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions typings/carouselElements.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type SliderInterface = React.ComponentType<SliderProps>;
*/
declare const Slider: SliderInterface;

type SlideProps<T extends React.ElementType = "div"> =
type SlideProps<T extends React.ElementType = React.ElementType> =
React.HTMLAttributes<T> & {
readonly className?: string;
readonly classNameHidden?: string;
Expand All @@ -47,8 +47,8 @@ type SlideInterface = React.ComponentType<SlideProps>;
*/
declare const Slide: SlideInterface;

type ImageWithZoomProps<T extends React.ElementType = "div"> =
React.HTMLAttributes<T> & {
type ImageWithZoomProps<T extends React.ElementType = React.ElementType> =
React.ComponentPropsWithoutRef<T> & {
readonly alt?: string;
readonly bgImageProps?: object;
readonly bgImageTag?: string;
Expand All @@ -65,8 +65,8 @@ type ImageWithZoomProps<T extends React.ElementType = "div"> =
type ImageWithZoomInterface = React.ComponentType<ImageWithZoomProps>;
declare const ImageWithZoom: ImageWithZoomInterface;

type ImageProps<T extends React.ElementType = "img"> =
React.HTMLAttributes<T> & {
type ImageProps<T extends React.ElementType = React.ElementType> =
React.ComponentPropsWithoutRef<T> & {
readonly alt?: string;
readonly children?: React.ReactNode;
readonly className?: string;
Expand Down