docs: tweak intro, add note w/ browser enforcement, FAQ #385
Merged
jonchurch merged 5 commits intoexpressjs:masterfrom Jan 16, 2026
Merged
docs: tweak intro, add note w/ browser enforcement, FAQ #385jonchurch merged 5 commits intoexpressjs:masterfrom
jonchurch merged 5 commits intoexpressjs:masterfrom
Conversation
- Rewrite intro to clarify this middleware sets response headers - Add [!IMPORTANT] callout explaining how CORS actually works - Add Common Misconceptions section addressing common confusions - Replace web.dev link with MDN reference in callout
jonchurch
force-pushed
the
docs/add-misconceptions-and-important
branch
from
eca5c8b to
5d39329
Compare
jonchurch
changed the title
4 tasks
bjohansebas
approved these changes
Jan 13, 2026
UlisesGascon
approved these changes
Jan 13, 2026
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! Just a small suggestion to bold some parts (totally optional)
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
bjohansebas
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an attempt to reduce confusion in the docs #384
This adds a block at the top of the docs to try and call out the simplest version of what CORS is and what to expect from the package
Also adds a misconceptions section we can link to when needed