Fixes #2084 #2089
Open
Fixes #2084 #2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
🚦 Lighthouse Results (Mobile & Desktop)
|
efekrskl
reviewed
Nov 3, 2025
| | `maxAge` | Set the max-age property of the Cache-Control header in milliseconds or a string in [ms format](https://www.npmjs.org/package/ms). | Number | 0 | | ||
| | `redirect` | Redirect to trailing "/" when the pathname is a directory. | Boolean | `true` | | ||
| | `setHeaders` | Function for setting HTTP headers to serve with the file. <br/><br/>See [setHeaders](#setHeaders) below. | Function | | | ||
| | `acceptRanges` | Enable or disable accepting ranged requests. Disabling this will not send the Accept-Ranges header and will ignore the contents of the Range request header. <br/><br/>See [acceptRanges](#acceptRanges) below. | Boolean | true | |
Contributor
There was a problem hiding this comment.
Could be better to put keyword inside backticks e.g Accept-Ranges
Comment on lines
63
to
73
| <h5 id='acceptRanges'>acceptRanges</h5> | ||
|
|
||
| Enable or disable accepting ranged requests, defaults to true. | ||
| Disabling this will not send `Accept-Ranges` and ignore the contents | ||
| of the `Range` request header. | ||
|
|
||
| <h5 id='cacheControl'>cacheControl</h5> | ||
|
|
||
| Enable or disable setting `Cache-Control` response header, defaults to | ||
| true. Disabling this will ignore the `immutable` and `maxAge` options. | ||
|
|
Contributor
There was a problem hiding this comment.
I don't think this section adds much, as it is the exact same description we have above
Akash-2006
changed the title
Contributor
|
Maybe you could put the It looks like you accidentally pushed some Gemfile changes. Other than that, looks good! |
Author
|
i removed the changes in the Gemfile.PR description i already have the fixes and the isssue number. Can you check it and let me know if everything is good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missisng accept ranges and cachecontrol in _includes/api/en/4x/express.static.md and _includes/api/en/5x/express.static.md