Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support returning promises on Session prototype methods #737

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Support returning promises on Session prototype methods #737

wants to merge 8 commits into from

Commits on Mar 22, 2020

  1. Support session methods with requiring callbacks to also return promises

    @whatl3y
    whatl3y committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    ed56d42 View commit details
    Browse the repository at this point in the history

  2. add tests for promisified versions of session methods

    @whatl3y
    whatl3y committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    dd69b1b View commit details
    Browse the repository at this point in the history

  3. Update to exact bluebird version for travis

    @whatl3y
    whatl3y committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    5cfe9ea View commit details
    Browse the repository at this point in the history

  4. Remove fn noop fallback (happens in reject or resolve function) and r… 

    …esolve linting errors
    @whatl3y
    whatl3y committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    add8beb View commit details
    Browse the repository at this point in the history

  5. Import Promise into test file for older versions of NodeJS

    @whatl3y
    whatl3y committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    7f43e67 View commit details
    Browse the repository at this point in the history

  6. Update docs to demonstrate promise and async/await usage

    @whatl3y
    whatl3y committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    e574f8f View commit details
    Browse the repository at this point in the history

  7. Wrap async/await examples in anonymous async functions and add ecmaVe… 

    …rsion 2017 to eslintrc
    @whatl3y
    whatl3y committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    a5b3a0a View commit details
    Browse the repository at this point in the history

  8. Conditionally return promises if no callback provided, and reinstate … 

    …chaining functionality if callback provided as opposed to promise being returned
    @whatl3y
    whatl3y committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    41fcaf7 View commit details
    Browse the repository at this point in the history