Skip to content

fix: lint action #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gusfcarvalho merged 4 commits into from
Dec 3, 2024
Merged

fix: lint action #145

gusfcarvalho merged 4 commits into from
Dec 3, 2024

Conversation

@gusfcarvalho
Copy link
Member

@gusfcarvalho gusfcarvalho commented Dec 3, 2024

No description provided.

Gustavo Carvalho added 2 commits December 3, 2024 06:41
fix: lint action
9c62776 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@productmadness.com>
fix: disable lint everywhere
49b6714 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@productmadness.com>
@github-actions github-actions bot added the size/S label Dec 3, 2024
fix: lint on pull requests only
3442bb6 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@productmadness.com>
@github-actions github-actions bot added size/S and removed size/S labels Dec 3, 2024
cfviotti
cfviotti reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@cfviotti cfviotti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This will help testing linter rules on github when opening #62 / #107

There are a few warnings right now, do they block the action from passing? If so, it's ok to add exceptions for them too.

cfviotti
cfviotti previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@cfviotti cfviotti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pre-approved this one. Should just need to remove the 2 AI comments and LGTM

fix: remove ai from file (now it was all me :D)
6b9b9f6 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@productmadness.com>
@github-actions github-actions bot added size/S and removed size/S labels Dec 3, 2024
@gusfcarvalho gusfcarvalho merged commit 965b3f0 into main Dec 3, 2024
2 checks passed
@gusfcarvalho gusfcarvalho deleted the gc/fix/lint-action branch December 3, 2024 22:05
@external-secrets-bot external-secrets-bot bot mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfviotti cfviotti cfviotti approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gusfcarvalho @cfviotti