Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump windows-sys from 0.52.0 to 0.59.0 #1106

Merged
merged 1 commit into from
Aug 29, 2024
Merged

build(deps): bump windows-sys from 0.52.0 to 0.59.0 #1106

merged 1 commit into from
Aug 29, 2024

Conversation

slyshykO
Copy link
Contributor

fix for #1082

@slyshykO slyshykO requested a review from cafkafk as a code owner August 29, 2024 16:25
@daviessm daviessm self-requested a review August 29, 2024 16:51
daviessm
daviessm approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@daviessm daviessm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working on Windows

cafkafk
cafkafk approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working on Windows

Thanks for testing this!

Also, thanks for fixing this @slyshykO, formatted the code so the CI checks would pass, LGTM 👍

@cafkafk cafkafk merged commit a7cc5a6 into eza-community:main Aug 29, 2024
19 checks passed
@cafkafk cafkafk mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviessm daviessm daviessm approved these changes

@cafkafk cafkafk cafkafk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Eza Pull-Requests
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slyshykO @daviessm @cafkafk