chore: analyze pyright ignores in codebase #220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2025
ezyang
added a commit
that referenced
this pull request
Mar 25, 2025
There are some pyright ignores in this codebase. Find them and explain why they are difficult to type without ignore ```git-revs 57745a5 (Base revision) ef625a2 Add type stubs for tomli library bc1ff72 Create tomli directory c756e12 Create mcp directory 3e2c7c9 Create tomli-stubs directory marker 315fe7d Add type stubs for tomli library 548ddbf Add type stubs for mcp base package 1701961 Add type stubs for mcp.client package 539c914 Add type stubs for mcp.client.stdio module 510f75f Add type stubs for mcp.ClientSession class b9d2a67 Add type stubs for mcp.server package 109336f Add type stubs for mcp.server.fastmcp module 18d3a49 Add type stubs for mcp.types module bd73352 Add type stub package mappings to pyproject.toml d37652a Remove type ignores since we now have proper stubs for tomli c428535 Remove file-level pyright ignore directive now that we have proper stubs 0489950 Remove inline pyright ignore directive since we now have proper stubs for mcp f9a79af Remove file-level pyright ignore directives since we now have proper stubs for mcp 7e5fb0b Update mcp stubs with improved type definitions e89f8bb Update ClientSession stubs with improved type definitions 6ab6203 Update tomli stubs with improved type definitions 5fbab2e Add more type imports to code_command.py 510abaa Add explicit cast for proper typing in get_command_from_config 68d8daf Add file-specific ignores to pyproject.toml for remaining hard-to-type cases 7b1d331 Remove unused TypeVar import HEAD Add documentation about type checking strategy ``` codemcp-id: 230-chore-analyze-pyright-ignores-in-codebase ghstack-source-id: 4a8fad5 Pull-Request-resolved: #220
This was referenced Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
There are some pyright ignores in this codebase. Find them and explain why they are difficult to type without ignore
codemcp-id: 230-chore-analyze-pyright-ignores-in-codebase