Skip to content

Conversation

@ezyang
Copy link
Owner

@ezyang ezyang commented Jun 4, 2025

Stack from ghstack (oldest at bottom):

These tests are failing, fix them:

FAILED tests/test_git_message.py::TestGitMessageHandling::test_append_new_metadata - AssertionError: 'feat: Add feature\n\nDescription\n\ncodemcp-id: abc-123\n'...
FAILED tests/test_git_message.py::TestGitMessageHandling::test_meta_ignored_except_codemcp_id - AssertionError: 'feat: Add feature\n\nother-key: value\n' != 'feat: Add fea...
FAILED tests/test_git_message.py::TestGitMessageHandling::test_single_line_subject_with_colon - AssertionError: 'feat: Add new feature\n\ncodemcp-id: abc-123\n' != 'feat: ...
FAILED e2e/test_init_project.py::InitProjectTest::test_init_project_complex_toml - AssertionError: 'lint' not found in "You are an AI assistant that helps use...

5d9c3ee  (Base revision)
1795ce0  Fix append_metadata_to_message to ensure proper blank line before trailers
bd3d36e  Snapshot before auto-test
0f64eff  Fix trailing newline issue in append_metadata_to_message
40a5d8e  Add command documentation to system prompt in init_project
HEAD     Auto-commit lint changes

codemcp-id: 1-fix-fix-failing-tests-for-git-message-handling-and

[ghstack-poisoned]
@ezyang ezyang closed this in 782a4ab Jun 4, 2025
dmerkert pushed a commit to dmerkert/codemcp that referenced this pull request Jun 4, 2025
These tests are failing, fix them:

FAILED tests/test_git_message.py::**TestGitMessageHandling::test_append_new_metadata** - AssertionError: 'feat: Add feature\n\nDescription\n\ncodemcp-id: abc-123\n'...
FAILED tests/test_git_message.py::**TestGitMessageHandling::test_meta_ignored_except_codemcp_id** - AssertionError: 'feat: Add feature\n\nother-key: value\n' != 'feat: Add fea...
FAILED tests/test_git_message.py::**TestGitMessageHandling::test_single_line_subject_with_colon** - AssertionError: 'feat: Add new feature\n\ncodemcp-id: abc-123\n' != 'feat: ...
FAILED e2e/test_init_project.py::**InitProjectTest::test_init_project_complex_toml** - AssertionError: 'lint' not found in "You are an AI assistant that helps use...

```git-revs
5d9c3ee  (Base revision)
1795ce0  Fix append_metadata_to_message to ensure proper blank line before trailers
bd3d36e  Snapshot before auto-test
0f64eff  Fix trailing newline issue in append_metadata_to_message
40a5d8e  Add command documentation to system prompt in init_project
HEAD     Auto-commit lint changes
```

codemcp-id: 1-fix-fix-failing-tests-for-git-message-handling-and
ghstack-source-id: f640a76
Pull-Request-resolved: ezyang#307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants