Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 각 feature의 embedding 생성 코드 구현 #11

Merged
merged 3 commits into from
Nov 26, 2024
Merged

[feat] 각 feature의 embedding 생성 코드 구현 #11

merged 3 commits into from
Nov 26, 2024

Conversation

22ema
Copy link
Collaborator

@22ema 22ema commented Nov 21, 2024

What is this PR 🔍

  • 각 feature 별로 embedding을 생성하는 함수 구현.
  • black formatter 적용으로 인해 inputs.py 포맷팅 수정.

Changes 🔑

  • inputs.py 포맷팅 수정
  • inputs.py 내 create_embedding_matrix() 함수 구현

To Reviewer 🙇‍♂️

  • black formatter 적용으로 인해 포맷팅 inputs.py commit에 변경점이 많습니다. 문제된다면 수정하도록 하겠습니다. 🙇‍♂️

@22ema 22ema changed the title [feat] [feat] embedding을 생성 코드 구현 Nov 21, 2024
@22ema 22ema changed the title [feat] embedding을 생성 코드 구현 [feat] embedding 생성 코드 구현 Nov 21, 2024
@22ema 22ema changed the title [feat] embedding 생성 코드 구현 [feat] 각 feature의 embedding 생성 코드 구현 Nov 21, 2024
@22ema 22ema self-assigned this Nov 22, 2024
f-lab-owen
f-lab-owen reviewed Nov 22, 2024
View reviewed changes
CATS/inputs.py Outdated Show resolved Hide resolved
CATS/inputs.py Show resolved Hide resolved
@22ema
Copy link
Collaborator Author

22ema commented Nov 24, 2024

말씀해주신 수정사항 반영 완료하였습니다.🙏🏻

@22ema 22ema merged commit f92e348 into main Nov 26, 2024
1 check passed
@22ema 22ema deleted the feat_#3_5 branch December 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-owen f-lab-owen f-lab-owen approved these changes

Assignees

@22ema 22ema

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@22ema @f-lab-owen