Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 콜백함수 구현 #14

Merged
merged 10 commits into from
Dec 8, 2024
Merged

[feat] 콜백함수 구현 #14

merged 10 commits into from
Dec 8, 2024

Conversation

22ema
Copy link
Collaborator

@22ema 22ema commented Nov 29, 2024

What is this PR 🔍

  • pytorch에는 별도로 학습시 사용할 수 있는 콜백함수가 없습니다. 그래서 tensorflow의 콜백함수를 가져와 사용하였습니다.
  • ModelCheckpoint 클래스 사용 시, 모델을 저장할때 torch.save()를 사용하도록 코드를 수정하였습니다.

Changes 🔑

  • create callbacks.py
  • create ModelCheckpointTorch
  • import History, ModelCheckpoint, EarlyStopping

To Reviewer 🙇‍♂️

  • ModelCheckpoint를 상속하여 on_epoch_end()를 수정할때, 부모 클래스와 동일한 네이밍으로 자식클래스를 생성하여도 괜찮을까요? DeepCTR_torch에서는 동일한 네임으로 자식클래스를 만들었지만 IDE상에서 수정을 권장하여 별도의 자식클래스 네이밍으로 구현하였습니다.

@22ema 22ema requested a review from f-lab-owen November 29, 2024 22:42
@22ema 22ema self-assigned this Nov 29, 2024
@f-lab-owen

This comment was marked as resolved.

@22ema

This comment was marked as resolved.

@22ema

This comment was marked as resolved.

CATS/callbacks.py Outdated Show resolved Hide resolved
CATS/callbacks.py Outdated Show resolved Hide resolved
@22ema
Copy link
Collaborator Author

22ema commented Dec 6, 2024

작성해주신 수정사항들 반영 완료하였습니다. 감사합니다. 🙇‍♂️

CATS/callbacks.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@f-lab-owen f-lab-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 :)

@22ema 22ema merged commit 03817f9 into main Dec 8, 2024
1 check passed
@22ema 22ema deleted the feat_#3_8 branch December 8, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants