Skip to content

[feat] BaseModel.compile 메서드 구현 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 1, 2025
Merged

Conversation

22ema
Copy link
Collaborator

@22ema 22ema commented Dec 20, 2024

What is this PR 🔍

  • 모델 학습에 필요한 loss function, metrics, optimizer를 세팅하는 함수와 각 서브모듈 구현

Changes 🔑

  • BaseModel._get_optim() 메서드 구현
  • BaseModel._get_loss_func_single() 메서드 구현
  • BaseModel._get_loss_func() 메서드 구현
  • BaseModel.compile() 메서드 구현

To Reviewer 🙇‍♂️

  • Unit Test 진행 시, library 버전 이슈 및 inputs.py 내 create_embedding_matrix() 함수 오타 이슈가 있어 작동을 하지 않습니다. 관련하여 이슈 등록 후, 수정하도록 하겠습니다.

@22ema 22ema requested a review from f-lab-owen December 20, 2024 02:27
@22ema 22ema self-assigned this Dec 20, 2024
@22ema
Copy link
Collaborator Author

22ema commented Dec 28, 2024

검토해주신 내용 수정 완료하였습니다. 감사합니다.

@22ema 22ema merged commit 9ea8a30 into main Jan 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants