Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3] feature들의 name 및 크기 정보를 반환하는 함수 구현 #9

Merged
merged 8 commits into from
Nov 18, 2024
Merged

[#3] feature들의 name 및 크기 정보를 반환하는 함수 구현 #9

merged 8 commits into from
Nov 18, 2024

Conversation

22ema
Copy link
Collaborator

@22ema 22ema commented Nov 7, 2024

What is this PR 🔍

  • feature들의 name을 읽어오기 위한 get_feature_names() 함수 구현
  • features들의 이름과 feature 크기 정보를 담은 dictionary를 반환하는 build_input_features() 함수 구현

Changes 🔑

  • CATS/inputs.py 파일 내 get_feature_names() 함수 구현 및 build_input_features() 함수 구현.

To Reviewer 🙇‍♂️

  • 각 함수의 코드에 부족한 부분이 없는지 검토 부탁드립니다.

@22ema 22ema requested a review from f-lab-owen November 7, 2024 07:52
@22ema 22ema self-assigned this Nov 7, 2024
f-lab-owen
f-lab-owen requested changes Nov 10, 2024
View reviewed changes
CATS/inputs.py Outdated Show resolved Hide resolved
CATS/inputs.py Outdated Show resolved Hide resolved
CATS/inputs.py Show resolved Hide resolved
CATS/inputs.py Show resolved Hide resolved
CATS/inputs.py Outdated Show resolved Hide resolved
CATS/inputs.py Outdated Show resolved Hide resolved
CATS/inputs.py Outdated Show resolved Hide resolved
@22ema
Copy link
Collaborator Author

22ema commented Nov 13, 2024 •
edited
Loading

code review 감사합니다. 리뷰 해주신 내용 수정 완료하였습니다.🙇‍♂️
features 변수명에 대한 내용은 검토 부탁 드립니다.

f-lab-owen
f-lab-owen approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@f-lab-owen f-lab-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다!

@22ema 22ema merged commit a930c6b into main Nov 18, 2024
1 check passed
@22ema 22ema deleted the feat_#3_3 branch November 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-owen f-lab-owen f-lab-owen approved these changes

Assignees

@22ema 22ema

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@22ema @f-lab-owen