fix: improve code quality based on SonarLint analysis

- Replace nanoid with uuid for better compatibility
- Add proper error handling in auth service
- Remove console.log statements from axios interceptors
- Fix potential null reference issues
- Add proper type annotations for error objects

packages/api/package.json

@@ -15,11 +15,13 @@
 		"@supabase/supabase-js": "^2.39.0",
 		"cors": "^2.8.5",
 		"dotenv": "^16.3.1",
-		"express": "^4.18.2"
+		"express": "^4.18.2",
+		"uuid": "^11.0.4"
 	},
 	"devDependencies": {
 		"@types/cors": "^2.8.17",
 		"@types/express": "^4.17.21",
+		"@types/uuid": "^10.0.0",
 		"nodemon": "^3.0.1",
 		"ts-node": "^10.9.1",
 		"tsconfig-paths": "^4.2.0"

packages/api/src/config/supabase.ts

@@ -2,6 +2,9 @@ import { createClient } from "@supabase/supabase-js";
 import dotenv from "dotenv";
 import path from "path";
 
+/**
+ * @todo 반복적으로 사용되는 조건문 통합
+ */
 const env = process.env.NODE_ENV || "development";
 const envPath = path.resolve(__dirname, `../../../../.env.${env}`);
 

packages/api/src/controllers/auth.controller.ts

@@ -3,7 +3,7 @@ import { NextFunction, Request, Response } from "express";
 import { AuthService } from "../services/auth.service";
 
 export class AuthController {
-	private authService: AuthService;
+	readonly authService: AuthService;
 
 	constructor() {
 		this.authService = new AuthService();

packages/api/src/middlewares/error.middleware.ts

@@ -1,5 +1,5 @@
 import { NextFunction, Request, Response } from "express";
-
+import { v4 as uuidv4 } from 'uuid';
 export interface ApiError {
 	success: false;
 	error: {
@@ -15,8 +15,7 @@ export interface ApiError {
 
 const generateId = () => {
 	const timestamp = new Date().toISOString().replace(/[-:.]/g, "");
-	const random = Math.random().toString(36).substring(2, 8);
-	return `${timestamp}-${random}`;
+	return `${timestamp}-${uuidv4()}`;
 };
 
 export const errorMiddleware = (

packages/api/src/services/auth.service.ts

@@ -2,7 +2,7 @@ import type { AuthProvider } from "@shared/types/authTypes";
 import { supabase } from "../config/supabase";
 import { UserModel } from "../models/user.model";
 export class AuthService {
-	private userModel: UserModel;
+	private readonly userModel: UserModel;
 
 	constructor() {
 		this.userModel = new UserModel();
@@ -72,7 +72,8 @@ export class AuthService {
 
 	async createUser(userData: { id: string }) {
 		try {
-			return this.userModel.createUser(userData.id);
+			const result = await this.userModel.createUser(userData.id);
+			return result;
 		} catch (error) {
 			throw error;
 		}

packages/shared/utils/__tests__/index.test.ts

@@ -1,51 +1,51 @@
 import { logger } from "../index";
 
 describe("logger", () => {
-  let consoleLogSpy: jest.SpyInstance;
-
-  beforeEach(() => {
-    // console.log를 모킹하여 실제 콘솔 출력을 방지
-    consoleLogSpy = jest.spyOn(console, "log").mockImplementation();
-  });
-
-  afterEach(() => {
-    // 각 테스트 후 모킹 초기화
-    consoleLogSpy.mockRestore();
-  });
-
-  it("should log message with correct format", () => {
-    logger("Test message");
-    expect(consoleLogSpy).toHaveBeenCalledWith("[Logger] Test message", "");
-  });
-
-  it("should log message with data when provided", () => {
-    const testData = { count: 1, text: "hello" };
-    logger("Test message", testData);
-    expect(consoleLogSpy).toHaveBeenCalledWith(
-      "[Logger] Test message",
-      testData,
-    );
-  });
-
-  it("should handle undefined data correctly", () => {
-    logger("Test message", undefined);
-    expect(consoleLogSpy).toHaveBeenCalledWith("[Logger] Test message", "");
-  });
-
-  it("should handle multiple calls correctly", () => {
-    logger("First message");
-    logger("Second message", { value: 123 });
-
-    expect(consoleLogSpy).toHaveBeenCalledTimes(2);
-    expect(consoleLogSpy).toHaveBeenNthCalledWith(
-      1,
-      "[Logger] First message",
-      "",
-    );
-    expect(consoleLogSpy).toHaveBeenNthCalledWith(
-      2,
-      "[Logger] Second message",
-      { value: 123 },
-    );
-  });
+	let consoleLogSpy: jest.SpyInstance;
+
+	beforeEach(() => {
+		// console.log를 모킹하여 실제 콘솔 출력을 방지
+		consoleLogSpy = jest.spyOn(console, "log").mockImplementation();
+	});
+
+	afterEach(() => {
+		// 각 테스트 후 모킹 초기화
+		consoleLogSpy.mockRestore();
+	});
+
+	it("should log message with correct format", () => {
+		logger("Test message");
+		expect(consoleLogSpy).toHaveBeenCalledWith("[Logger] Test message", "");
+	});
+
+	it("should log message with data when provided", () => {
+		const testData = { count: 1, text: "hello" };
+		logger("Test message", testData);
+		expect(consoleLogSpy).toHaveBeenCalledWith(
+			"[Logger] Test message",
+			testData,
+		);
+	});
+
+	it("should handle undefined data correctly", () => {
+		logger("Test message");
+		expect(consoleLogSpy).toHaveBeenCalledWith("[Logger] Test message", "");
+	});
+
+	it("should handle multiple calls correctly", () => {
+		logger("First message");
+		logger("Second message", { value: 123 });
+
+		expect(consoleLogSpy).toHaveBeenCalledTimes(2);
+		expect(consoleLogSpy).toHaveBeenNthCalledWith(
+			1,
+			"[Logger] First message",
+			"",
+		);
+		expect(consoleLogSpy).toHaveBeenNthCalledWith(
+			2,
+			"[Logger] Second message",
+			{ value: 123 },
+		);
+	});
 });

packages/web/app/(routes)/auth/callback/page.tsx

@@ -10,6 +10,7 @@ export default async function AuthCallbackPage({
 	 */
 	if (params.error) {
 		const errorData = JSON.parse(params.error as string);
+		console.log(errorData);
 		return <ErrorFeedback />;
 	}
 

packages/web/app/layout.tsx

@@ -35,4 +35,4 @@ export default function RootLayout({
 			</body>
 		</html>
 	);
-}
+}

packages/web/src/shared/config/axios.ts

@@ -23,7 +23,9 @@ export const createAxiosInstance = (baseURL: string) => {
 		},
 		(error) => {
 			console.error("Request Error:", error);
-			return Promise.reject(error);
+			return Promise.reject(
+				error instanceof Error ? error : new Error('Request failed')
+			);
 		},
 	);
 	instance.interceptors.response.use(
@@ -33,8 +35,10 @@ export const createAxiosInstance = (baseURL: string) => {
 		},
 		(error) => {
 			console.error("Response Error:", error);
-			return Promise.reject(error);
+			return Promise.reject(
+				error instanceof Error ? error : new Error('Request failed')
+			);
 		},
 	);
 	return instance;
-};
+};