재시도 로직 구현 및 테스트 추가 #7
Merged
+151
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
f-lab-lyan
reviewed
Jan 8, 2025
| override fun onFailure(call: okhttp3.Call, e: IOException) { | ||
| var tmpAttempt = attempt | ||
| tmpAttempt++ | ||
| if (tmpAttempt <= maxAttempts && config.isRetryEnabled) { |
There was a problem hiding this comment.
재시도 로직은 좋은 것 같은데요. 음 ... 만약 재시도를 해야하는 상황이라면, 요청을 받는 서버쪽에 문제가 생겼을 가능성이 높은데, 그 타이밍에 계속 재시도를 하는 것이 좋은가? 에 대해서 생각해보면, 좋을 것 같네요. (이 문제는 답은 없습니다만...) 그리고 재시도 하는 동안 (정확히는 sleep하는동안) 요청이 계속 들어올텐데, 그럼 그런 요청들도 문제가 생겨서 재시도 로직을 타게되면, 결과적으로 많은 로그들이 쌓이게 되지 않을까요?
f-lab-lyan
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경 사항
재시도 로직 구현
JvmNetworkClient내부makePostRequestAsync메서드에 재시도 기능 추가.maxRetries)만큼 요청을 반복.retryDelayMillis값과 지수 백오프(backoffFactor)를 통해 증가하도록 설정.테스트 코드 작성
MainIntegrationTest.kt에 재시도 로직 검증 테스트 추가.