FIx: Data를 Entity로 변환하는 과정을 메서드로 분리

f-lab-edu · Jun 4, 2024 · de9d3e5 · de9d3e5
1 parent 9c2e460
commit de9d3e5
Showing 1 changed file with 16 additions and 21 deletions.
diff --git a/HomeCafeRecipes/HomeCafeRecipes/Data/FirebaseRemoteDataSource.swift b/HomeCafeRecipes/HomeCafeRecipes/Data/FirebaseRemoteDataSource.swift
@@ -20,17 +20,7 @@ class FirebaseRemoteDataSource {
                 completion(.success([]))
                 return
             }
-            let feedItems = documents.compactMap { doc -> FeedItem? in
-                let data = doc.data()
-                guard
-                    let id = data["id"] as? String,
-                    let title = data["title"] as? String,
-                    let imageURLs = data["imageURLs"] as? [String] else {
-                    return nil
-                }
-                return FeedItem(id: id, title: title, imageURLs: imageURLs)
-
-            }
+            let feedItems = self.convertToFeedItems(documents)
             completion(.success(feedItems))
         }
     }
@@ -48,19 +38,24 @@ class FirebaseRemoteDataSource {
                     completion(.success([]))
                     return
                 }
-                let feedItems = documents.compactMap { doc -> FeedItem? in
-                    let data = doc.data()
-                    guard
-                        let id = data["id"] as? String,
-                        let title = data["title"] as? String,
-                        let imageURLs = data["imageURLs"] as? [String] else {
-                        return nil
-                    }
-                    return FeedItem(id: id, title: title, imageURLs: imageURLs)
-                }
+
+                let feedItems = self.convertToFeedItems(documents)
                 completion(.success(feedItems))
             }
     }
+
+    private func convertToFeedItems(_ documents: [QueryDocumentSnapshot]) -> [FeedItem] {
+        return documents.compactMap { doc -> FeedItem? in
+            let data = doc.data()
+            guard
+                let id = data["id"] as? String,
+                let title = data["title"] as? String,
+                let imageURLs = data["imageURLs"] as? [String] else {
+                return nil
+            }
+            return FeedItem(id: id, title: title, imageURLs: imageURLs)
+        }
+    }
 
 }